WIP Hypershift BM - Agent based via Assisted Installer with IP echo server - #83029
WIP Hypershift BM - Agent based via Assisted Installer with IP echo server#83029asood-rh wants to merge 7 commits into
Conversation
Add metal-ds-hypershift-agent-mce-guest-f14 job for OCP 5.0 Add HyperShift agent MCE guest debug job to the 5.0 amd64-nightly config with a 24h wait step for cluster inspection. Update MCE_VERSION to 2.12 and set LVM_OPERATOR_SUB_CHANNEL to auto-detect
The metal-ds-hypershift-agent-mce-guest-f14 job used MCE_VERSION 2.12, which doesn't exist in the mce-dev-catalog. Replace it with metal-ds-hypershift-agent-ovn-egressip-debug using MCE 2.17 (the correct version for OCP 5.0), and add ipecho provision/deprovision step-registry refs that deploy a Python HTTP server on the dev-scripts provisioning host (192.168.111.1:9095). The ipecho server sits on the same L2 segment (ostestbm bridge) as guest cluster worker VMs, enabling EgressIP SNAT verification without routing or NAT in the path.
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe change adds HyperShift agent OVN ipecho provision and deprovision steps. It adds a scheduled bare-metal OVN egress-IP debug job with provisioning, a wait step, and cleanup. ChangesHyperShift OVN ipecho debug flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ScheduledJob
participant ProvisionStep
participant DevScriptsHost
participant IPEchoService
participant WaitStep
participant DeprovisionStep
ScheduledJob->>ProvisionStep: Start ipecho provisioning
ProvisionStep->>DevScriptsHost: Install and configure service
DevScriptsHost->>IPEchoService: Start systemd service
ProvisionStep->>IPEchoService: Check readiness
IPEchoService-->>ProvisionStep: Return source IP
ScheduledJob->>WaitStep: Run wait test
ScheduledJob->>DeprovisionStep: Start cleanup
DeprovisionStep->>DevScriptsHost: Stop and remove service
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asood-rh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
do-not-merge/invalid-owners-file
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
- Reorder steps sections alphabetically (post/pre/test) to satisfy
ci-operator-config-metadata validation
- Add OWNERS files to intermediate directories hypershift/agent/ovn/
and hypershift/agent/ovn/ipecho/ for step-registry-metadata check
- Set LVM_OPERATOR_SUB_CHANNEL to stable-4.22 since stable-5.0
channel does not exist yet
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
- Strip trailing newlines from metadata.json files to match
make registry-metadata output format
- Reorder steps sections alphabetically (post/pre/test) for
ci-operator-config-metadata validation
- Add OWNERS files to intermediate directories hypershift/agent/ovn/
and hypershift/agent/ovn/ipecho/
- Change LVM_OPERATOR_SUB_CHANNEL from stable-4.22 to stable-4.21
to match other working OCP 5.0 jobs
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The operatorhub-subscribe-lvm-operator step defaults to subscribing from the redhat-operators catalog, which lacks the required channel for OCP 5.0. The lvms-catalogsource step already creates a custom catalog source using the correct index image, but the subscription was not pointed at it. Add LVM_OPERATOR_SUB_SOURCE: lvm-catalogsource to match all other working OCP 5.0 jobs
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The lvm-catalogsource index image (v5.0) only contains channels stable-5.0 and stable-4.22. The subscription was failing because stable-4.21 does not exist in that index. Other OCP 5.0 jobs use stable-4.21 with the redhat-operators catalog, but our job uses lvm-catalogsource which has different channel availability.
|
@asood-rh, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse abort |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The hypershift-mce-conf-os-images step requires the assisted-service-scripts image (from: assisted-service-scripts), but it was not declared in the release-5.0 amd64-nightly base_images, causing ErrImagePull failures in metal-ds-hypershift-agent jobs
|
The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing
|
|
[REHEARSALNOTIFIER]
A total of 337 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-hypershift-agent-ovn-egressip-debug |
|
@asood-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@asood-rh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary by CodeRabbit
stable-5.0to match the available catalog index.